Fix parsing of file based template loading

We support three different settings in templates * "settings" : { "index" : { "number_of_shards" : 12 } } * "settings" : { "index.number_of_shards" : 12 } * "settings" : { "number_of_shards" : 12 } The latter one was not supported by the fix in elastic#4235 This commit fixes this issue and uses randomized testing to test any of the three cases above when running integration tests. Closes elastic#4411
mute · Dec 17, 2013 · 1dd1653 · 1dd1653
1 parent 96517d1
commit 1dd1653
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 3 deletions.
diff --git a/src/main/java/org/elasticsearch/cluster/metadata/IndexTemplateMetaData.java b/src/main/java/org/elasticsearch/cluster/metadata/IndexTemplateMetaData.java
@@ -303,7 +303,15 @@ public static IndexTemplateMetaData fromXContent(XContentParser parser) throws I
                     currentFieldName = parser.currentName();
                 } else if (token == XContentParser.Token.START_OBJECT) {
                     if ("settings".equals(currentFieldName)) {
-                        builder.settings(ImmutableSettings.settingsBuilder().put(SettingsLoader.Helper.loadNestedFromMap(parser.mapOrdered())));
+                        ImmutableSettings.Builder templateSettingsBuilder = ImmutableSettings.settingsBuilder();
+                        for (Map.Entry<String, String> entry : SettingsLoader.Helper.loadNestedFromMap(parser.mapOrdered()).entrySet()) {
+                            if (!entry.getKey().startsWith("index.")) {
+                                templateSettingsBuilder.put("index." + entry.getKey(), entry.getValue());
+                            } else {
+                                templateSettingsBuilder.put(entry.getKey(), entry.getValue());
+                            }
+                        }
+                        builder.settings(templateSettingsBuilder.build());
                     } else if ("mappings".equals(currentFieldName)) {
                         while ((token = parser.nextToken()) != XContentParser.Token.END_OBJECT) {
                             if (token == XContentParser.Token.FIELD_NAME) {

diff --git a/src/test/java/org/elasticsearch/indices/template/IndexTemplateFileLoadingTests.java b/src/test/java/org/elasticsearch/indices/template/IndexTemplateFileLoadingTests.java
@@ -38,7 +38,7 @@
 /**
  *
  */
-@ClusterScope(scope= Scope.SUITE, numNodes=1)
+@ClusterScope(scope=Scope.SUITE, numNodes=1)
 public class IndexTemplateFileLoadingTests extends ElasticsearchIntegrationTest {
 
     @Rule
@@ -57,7 +57,8 @@ protected Settings nodeSettings(int nodeOrdinal) {
             templatesDir.mkdir();
 
             File dst = new File(templatesDir, "template.json");
-            String template = Streams.copyToStringFromClasspath("/org/elasticsearch/indices/template/template.json");
+            // random template, one uses the 'setting.index.number_of_shards', the other 'settings.number_of_shards'
+            String template = Streams.copyToStringFromClasspath("/org/elasticsearch/indices/template/template" + randomInt(1) + ".json");
             Files.write(template, dst, Charsets.UTF_8);
         } catch (Exception e) {
             throw new RuntimeException(e);

diff --git a/...sticsearch/indices/template/template.json → ...ticsearch/indices/template/template0.json b/...sticsearch/indices/template/template.json → ...ticsearch/indices/template/template0.json
diff --git a/src/test/java/org/elasticsearch/indices/template/template1.json b/src/test/java/org/elasticsearch/indices/template/template1.json
@@ -0,0 +1,7 @@
+{
+    "template" : "foo*",
+    "settings" : {
+        "number_of_shards": 10,
+        "number_of_replicas": 0
+    }
+}
diff --git a/src/test/java/org/elasticsearch/indices/template/template2.json b/src/test/java/org/elasticsearch/indices/template/template2.json
@@ -0,0 +1,9 @@
+{
+    "template" : "foo*",
+    "settings" : {
+        "index" : {
+            "number_of_shards": 10,
+            "number_of_replicas": 0
+        }
+    }
+}