Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geo: inconsistent handling of out of bounds coordinates in different geo shapes #43916

Open
imotov opened this issue Jul 3, 2019 · 3 comments
Open

Geo: inconsistent handling of out of bounds coordinates in different geo shapes #43916

imotov opened this issue Jul 3, 2019 · 3 comments
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@imotov
Copy link
Contributor

imotov commented Jul 3, 2019

We allow out of bounds coordinates in linestrings and polygons, but not in points. In the following example the indexing of LINESTRING succeeds but the indexing of MULTIPOINT with the same set of coordinates fails.

DELETE test

PUT test
{
  "mappings": {
    "properties": {
      "shape": {
        "type": "geo_shape"
      }
    }
  }
}

PUT test/_doc/1
{
  "shape": "LINESTRING (160 0, 200 10)"
}


PUT test/_doc/2
{
  "shape": "MULTIPOINT (160 0, 200 10)"
}
@imotov imotov added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes labels Jul 3, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@Hohol
Copy link
Contributor

Hohol commented Jul 5, 2019

I'd like to take this.

@imotov
Copy link
Contributor Author

imotov commented Jul 5, 2019

@Hohol I am currently refactoring this code as part of #40908 so making this change now doesn't make much sense. Ping me by email or by PM on https://discuss.elastic.co/ and we can find something else to work on that matches your interest.

@imotov imotov mentioned this issue Jul 11, 2019
Merged
@imotov imotov mentioned this issue Aug 29, 2019
Closed
imotov added a commit to imotov/elasticsearch that referenced this issue Oct 8, 2019
@imotov
Geo: implement proper handling of out of bounds geo points
02a158c 
This is the first iteration in improving of handling of out of
bounds geopoints with a latitude outside of the -90 - +90 range
and a longitude outside of the -180 - +180 range.

Relates to elastic#43916
@imotov imotov mentioned this issue Oct 8, 2019
Merged
imotov added a commit that referenced this issue Oct 9, 2019
@imotov
Geo: implement proper handling of out of bounds geo points (#47734)
e3adedf 
This is the first iteration in improving of handling of out of
bounds geopoints with a latitude outside of the -90 - +90 range
and a longitude outside of the -180 - +180 range.

Relates to #43916
imotov added a commit that referenced this issue Oct 9, 2019
@imotov
Geo: implement proper handling of out of bounds geo points (#47734)
12e4e7e 
This is the first iteration in improving of handling of out of
bounds geopoints with a latitude outside of the -90 - +90 range
and a longitude outside of the -180 - +180 range.

Relates to #43916
imotov added a commit to imotov/elasticsearch that referenced this issue Oct 11, 2019
@imotov
Geo: improve handling of out of bounds points in linestrings
b5c9281 
Brings handling of out of bounds points in linestrings in line with
points. Now points with latitude above 90 and below -90 are handled
the same way as for points by adjusting the longitude by moving it by
180 degrees.

Relates to elastic#43916
imotov added a commit to imotov/elasticsearch that referenced this issue Oct 11, 2019
@imotov
Geo: improve handling of out of bounds points in linestrings
dcdfa08 
Brings handling of out of bounds points in linestrings in line with
points. Now points with latitude above 90 and below -90 are handled
the same way as for points by adjusting the longitude by moving it by
180 degrees.

Relates to elastic#43916
@imotov imotov mentioned this issue Oct 11, 2019
Merged
imotov added a commit that referenced this issue Oct 23, 2019
@imotov
Geo: improve handling of out of bounds points in linestrings (#47939)
2e7d62c 
Brings handling of out of bounds points in linestrings in line with
points. Now points with latitude above 90 and below -90 are handled
the same way as for points by adjusting the longitude by moving it by
180 degrees.

Relates to #43916
imotov added a commit that referenced this issue Oct 23, 2019
@imotov
Geo: improve handling of out of bounds points in linestrings (#47939)
bdbc353 
Brings handling of out of bounds points in linestrings in line with
points. Now points with latitude above 90 and below -90 are handled
the same way as for points by adjusting the longitude by moving it by
180 degrees.

Relates to #43916
@imotov imotov mentioned this issue Oct 28, 2019
Open
This was referenced Feb 3, 2020
Closed
Closed
@rjernst rjernst added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rjernst @imotov @Hohol @elasticmachine