-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geo: implement proper handling of out of bounds geo points #47734
Conversation
This is the first iteration in improving of handling of out of bounds geopoints with a latitude outside of the -90 - +90 range and a longitude outside of the -180 - +180 range. Relates to elastic#43916
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
@elasticmachine run elasticsearch-ci/2 |
@@ -160,8 +161,9 @@ public Geometry visit(MultiPolygon multiPolygon) { | |||
|
|||
@Override | |||
public Geometry visit(Point point) { | |||
//TODO: Just remove altitude for now. We need to add normalization later | |||
return new Point(point.getX(), point.getY()); | |||
double[] latlon = new double[]{point.getX(), point.getY()}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a difference between normalizePoint
and calling normalizeLon
and normalizeLat
directly on these values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible to normalize longitude alone. That doesn't work for latitude thought since when you go over the pole, the longitude flips by 180 degrees.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah. thanks for clarifying
This is the first iteration in improving of handling of out of bounds geopoints with a latitude outside of the -90 - +90 range and a longitude outside of the -180 - +180 range. Relates to #43916
This is the first iteration in improving of handling of out of
bounds geopoints with a latitude outside of the -90 - +90 range
and a longitude outside of the -180 - +180 range.
Relates to #43916