Geo: implement proper handling of out of bounds geo points #47734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first iteration in improving of handling of out of bounds geopoints with a latitude outside of the -90 - +90 range and a longitude outside of the -180 - +180 range. Relates to elastic#43916
imotov
added
>bug
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
|
@elasticmachine run elasticsearch-ci/2 |
talevy
reviewed
Oct 8, 2019
| @@ -160,8 +161,9 @@ public Geometry visit(MultiPolygon multiPolygon) { | |||
|
|
|||
| @Override | |||
| public Geometry visit(Point point) { | |||
| //TODO: Just remove altitude for now. We need to add normalization later | |||
| return new Point(point.getX(), point.getY()); | |||
| double[] latlon = new double[]{point.getX(), point.getY()}; | |||
There was a problem hiding this comment.
is there a difference between normalizePoint and calling normalizeLon and normalizeLat directly on these values?
There was a problem hiding this comment.
It is possible to normalize longitude alone. That doesn't work for latitude thought since when you go over the pole, the longitude flips by 180 degrees.
talevy
approved these changes
Oct 8, 2019
imotov
added a commit
that referenced
this pull request
Oct 9, 2019
This is the first iteration in improving of handling of out of bounds geopoints with a latitude outside of the -90 - +90 range and a longitude outside of the -180 - +180 range. Relates to #43916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first iteration in improving of handling of out of
bounds geopoints with a latitude outside of the -90 - +90 range
and a longitude outside of the -180 - +180 range.
Relates to #43916