Some APIs don't contain information from http status in the body

[honzakral]

When the information is only in the HTTP status code, which is often not communicated to the client code, it can get lost.

For index api which doesn't distinguish between a document being created and re-indexed I propose to add a created field to the resulting json:

# curl -X PUT localhost:9200/t/i/1?pretty -d '{}'
{
    "ok" : true,
    "_index" : "t",
    "_type" : "i",
    "_id" : "1",
    "_version" : 1,
    "created": true
}

# curl -X PUT localhost:9200/t/i/1?pretty -d '{}'
{
    "ok" : true,
    "_index" : "t",
    "_type" : "i",
    "_id" : "1",
    "_version" : 2,
    "created": false
}

If there are any other API endpoints that doesn't replicate the information from http status in the json body add them in this single issue.

[brusic]

Wouldn't the _version field denote whether or not a document was created or updated? Or course, this method would not work with applications that provide their own versioning mechanism.

The bulk API returns the type of action executed (IndexResponse, DeleteResponse, UpdateResponse), perhaps the API should return the action type and not simply created or not (but that might be redundant in a few settings).

[honzakral]

the _version field is only telling when using automatic versioning and even then I wouldn't feel comfortable forcing people to check for version number in order to determine something like that - seems arbitrary and brittle.

[brusic]

I agree with you, which is why I added the last sentence/paragraph. I am currently using the _version method, but would love to move away from it.

My point was rather than having "created": true, it should perhaps be something like "type": "created".

[clintongormley]

Given that the bulk API now returns an HTTP status code with each entry, i think the consistent way to do this would be the same, ie include status: 201|200

[karmi]

I vote for status: 201, status: 200, status: 404, etc, i.e. using the numerical HTTP status codes.

The biggest benefit is that we don't have to invent any names and everybody can translate these codes to meaningful values themselves easily, potentially even leveraging existing dictionary in their codebase...

[dadoonet]

+1 for status: 200 etc...

[honzakral]

Fixed by #4635