New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make exists, found, not_found consistent #4480
Labels
Comments
If we look at the discussion here: #4416 (comment) WDYT? |
ghost
assigned dakrone
Jan 2, 2014
I don't think we should do status here, the status is already returned in the response, and for the non error use case, its much nicer to be descriptive, yet in a consistent manner. |
also, I would add that the index action should have a "created" flag in the rest response. |
Merged in 2cb40fc |
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this issue
Jan 8, 2014
This change reflects the background-incompatible change from elastic/elasticsearch#4480 Related: d540aa6
javanna
added a commit
that referenced
this issue
Jan 16, 2014
- Removed "ok": true from response examples - Added "created" flag to index response examples - Replaced exists flag with found in delete response examples
brusic
pushed a commit
to brusic/elasticsearch
that referenced
this issue
Jan 19, 2014
- Removed "ok": true from response examples - Added "created" flag to index response examples - Replaced exists flag with found in delete response examples
picandocodigo
pushed a commit
to elastic/elastic-transport-ruby
that referenced
this issue
Jun 7, 2021
This change reflects the background-incompatible change from elastic/elasticsearch#4480 Related: d540aa6
renaperes824
added a commit
to renaperes824/ruby-elastic-transport
that referenced
this issue
Sep 12, 2022
This change reflects the background-incompatible change from elastic/elasticsearch#4480 Related: d540aa6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The GET and multi_get APIs return
{"exists": true|false}
while the DELETE and bulk delete APIs return{"found": true|false}
, and the DeleteResponse class usesnotFound
.All of these should be changed to use
found
, in order to make things more consistent.The text was updated successfully, but these errors were encountered: