Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILM: _retry using wildcard should skip indices that are not managed by ILM #44188

Closed
ppf2 opened this issue Jul 10, 2019 · 2 comments
Closed
Assignees
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team

Comments

@ppf2
Copy link
Member

ppf2 commented Jul 10, 2019

6.7.0

When using POST */_ilm/retry to retry on all indices, ILM will throw the following illegal argument exception:

{
  "error": {
    "root_cause": [
      {
        "type": "illegal_argument_exception",
        "reason": "cannot retry an action for an index [.monitoring-kibana-6-2019.07.10] that has not encountered an error when running a Lifecycle Policy"
      }
    ],
    "type": "illegal_argument_exception",
    "reason": "cannot retry an action for an index [.monitoring-kibana-6-2019.07.10] that has not encountered an error when running a Lifecycle Policy"
  },
  "status": 400
}

The reason statement indicates that it is because .monitoring-kibana-6-2019.07.10 does not have a step error.

But .monitoring-kibana-6-2019.07.10 is not even an index managed by ILM to begin with:

{
  "indices" : {
    ".monitoring-kibana-6-2019.07.10" : {
      "index" : ".monitoring-kibana-6-2019.07.10",
      "managed" : false
    }
  }
}

The retry API should skip over indices that are not managed by ILM .

@ppf2 ppf2 added the :Data Management/ILM+SLM Index and Snapshot lifecycle management label Jul 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

probakowski added a commit to probakowski/elasticsearch that referenced this issue Jan 22, 2020
This change makes `_retry` ILM endpoint to skip indices that are not
managed by the ILM (i.e. don't have ILM metadata stored) instead of
throwing exception.
This allows user to call `*/_ilm/retry` and the request won't fail
because of unmanaged indices (for example .monitoring-kibana-*)

Closes elastic#44188
@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
@joegallo joegallo self-assigned this Sep 29, 2020
@joegallo
Copy link
Contributor

I talked with @dakrone about this one, and we think that given that automatic retries should be much more effective from 7.13.0 on (because of #48183 and its many associated PRs), that this is probably no longer necessary and can be skipped. Of course, feel free to reopen this if we've missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants