Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FsHealthServiceTests testFailsHealthOnIOException on Windows #59380

Closed
davidkyle opened this issue Jul 13, 2020 · 3 comments · Fixed by #59387
Closed

FsHealthServiceTests testFailsHealthOnIOException on Windows #59380

davidkyle opened this issue Jul 13, 2020 · 3 comments · Fixed by #59387
Assignees
@DaveCTurner
Labels
:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed Meta label for distributed team >test-failure Triaged test failures from CI

Comments

@davidkyle
Copy link
Member

davidkyle commented Jul 13, 2020 •
edited

Build scan:
https://gradle-enterprise.elastic.co/s/schg2cx7kb3ja
https://gradle-enterprise.elastic.co/s/avmtx56geouvy
https://gradle-enterprise.elastic.co/s/kkawj75b45nzc

Repro line:

 gradlew ':server:test' --tests "org.elasticsearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnIOException" \
  -Dtests.seed=383792DA00F947A9 \
  -Dtests.security.manager=true \
  -Dtests.locale=sv-SE \
  -Dtests.timezone=AGT \
  -Druntime.java=11

Reproduces locally?:
Unknown, Windows innit

Applicable branches:
Master, 7.x

Failure history:
Regularly

https://build-stats.elastic.co/app/kibana#/discover?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-7d,mode:quick,to:now))&_a=(columns:!(branch,build_url,build.branch,build.console-url),index:b646ed00-7efc-11e8-bf69-63c8ef516157,interval:auto,query:(language:lucene,query:'FsHealthServiceTests%20testFailsHealthOnIOException'),sort:!(process.time-start,desc))

Failure excerpt:

java.lang.AssertionError: expected:<UNHEALTHY> but was:<HEALTHY>
	at __randomizedtesting.SeedInfo.seed([98825EFCB7B3E2A5:FC2CB339E1C9370]:0)
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.elasticsearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnIOException(FsHealthServiceTests.java:119)
@davidkyle davidkyle added >test-failure Triaged test failures from CI :Core/Infra/Resiliency Keep running when everything is ok. Die quickly if things go horribly wrong. labels Jul 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Resiliency)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 13, 2020
@davidkyle davidkyle mentioned this issue Jul 13, 2020
Merged
@DaveCTurner DaveCTurner self-assigned this Jul 13, 2020
@DaveCTurner DaveCTurner added :Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. and removed :Core/Infra/Resiliency Keep running when everything is ok. Die quickly if things go horribly wrong. labels Jul 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Cluster Coordination)

@elasticmachine elasticmachine added Team:Distributed Meta label for distributed team and removed Team:Core/Infra Meta label for core/infra team labels Jul 13, 2020
davidkyle added a commit that referenced this issue Jul 13, 2020
@davidkyle
Mute FsHealthServiceTests testFailsHealthOnIOException (#59382)
ef8b414 
For #59380
davidkyle added a commit that referenced this issue Jul 13, 2020
@davidkyle
Mute FsHealthServiceTests testFailsHealthOnIOException (#59382)
7dcd943 
For #59380
@davidkyle
Copy link
Member Author

Muted on master: ef8b414 and 7.x: 7dcd943

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Jul 13, 2020
@DaveCTurner
Fix FSHealthServiceTests on Windows
9529b21 
In elastic#52680 we introduced a new health check mechanism. This commit fixes
up some related test failures on Windows.

Closes elastic#59380
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Jul 13, 2020
@DaveCTurner
Fix FSHealthServiceTests on Windows
e8f389f 
In elastic#52680 we introduced a new health check mechanism. This commit fixes
up some related test failures on Windows caused by erroneously assuming
that all paths begin with `/`.

Closes elastic#59380
@DaveCTurner DaveCTurner mentioned this issue Jul 13, 2020
Merged
DaveCTurner added a commit that referenced this issue Jul 13, 2020
@DaveCTurner
Fix FSHealthServiceTests on Windows (#59387)
e63f2f8 
In #52680 we introduced a new health check mechanism. This commit fixes
up some related test failures on Windows caused by erroneously assuming
that all paths begin with `/`.

Closes #59380
DaveCTurner added a commit that referenced this issue Jul 13, 2020
@DaveCTurner
Fix FSHealthServiceTests on Windows (#59387)
3fb9dcc 
In #52680 we introduced a new health check mechanism. This commit fixes
up some related test failures on Windows caused by erroneously assuming
that all paths begin with `/`.

Closes #59380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaveCTurner DaveCTurner

Labels
:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed Meta label for distributed team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix FSHealthServiceTests on Windows DaveCTurner/elasticsearch
3 participants
@davidkyle @DaveCTurner @elasticmachine