Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline serialization when retrieving spatial data through fields. #60259

Closed
jtibshirani opened this issue Jul 28, 2020 · 2 comments · Fixed by #60413
Closed

Streamline serialization when retrieving spatial data through fields. #60259

jtibshirani opened this issue Jul 28, 2020 · 2 comments · Fixed by #60413
Assignees
@imotov
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement :Search/Search Search-related issues that do not fall into other categories Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Meta label for search team

Comments

@jtibshirani
Copy link
Contributor

In #59821 we added support for retrieving spatial values like geo points using the fields parameter. To keep the PR well-scoped, we adopted a simple but inefficient serialization strategy: parsed geometry object -> xContent -> simple Java object.

We plan to streamline the serialization by converting directly from geometry object -> simple Java object. It is important to avoid unnecessary conversions, as some geometry objects can be quite large (like polygons representing a complex boundary).

Relates to #55363.
@jtibshirani jtibshirani added >enhancement :Analytics/Geo Indexing, search aggregations of geo points and shapes :Search/Search Search-related issues that do not fall into other categories labels Jul 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Meta label for search team labels Jul 28, 2020
@imotov imotov mentioned this issue Jul 29, 2020
Merged
imotov added a commit that referenced this issue Jul 29, 2020
@imotov
Streamline GeoJSON to map serialization (#60413)
2e04a4e 
Optimizes GeoJSON to map serialization when retrieving spatial data through
`fields`.

Closes #60259
imotov added a commit to imotov/elasticsearch that referenced this issue Jul 29, 2020
@imotov
Streamline GeoJSON to map serialization (elastic#60413)
98abe6b 
Optimizes GeoJSON to map serialization when retrieving spatial data through
`fields`.

Closes elastic#60259
@imotov imotov mentioned this issue Jul 29, 2020
Merged
imotov added a commit that referenced this issue Jul 29, 2020
@imotov
Streamline GeoJSON to map serialization (#60413) (#60429)
00a1949 
Optimizes GeoJSON to map serialization when retrieving spatial data through
fields.

Closes #60259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement :Search/Search Search-related issues that do not fall into other categories Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Streamline GeoJSON to map serialization imotov/elasticsearch
3 participants
@imotov @jtibshirani @elasticmachine