Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline GeoJSON to map serialization #60413

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Streamline GeoJSON to map serialization #60413

merged 2 commits into from
Jul 29, 2020

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Jul 29, 2020

Optimizes GeoJSON to map serialization when retrieving spatial data through
fields.

Closes #60259

@imotov
Streamline GeoJSON to map serialization
f8d5463 
Optimizes GeoJSON to map serialization when retrieving spatial data through
`fields`.

Closes elastic#60259
@imotov imotov added :Analytics/Geo Indexing, search aggregations of geo points and shapes :Search/Search Search-related issues that do not fall into other categories >refactoring v8.0.0 v7.10.0 labels Jul 29, 2020
@imotov imotov requested a review from jtibshirani July 29, 2020 17:28
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Meta label for search team labels Jul 29, 2020
jtibshirani
jtibshirani approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I like the testing strategy of checking consistency with the xContent representation.

@imotov imotov merged commit 2e04a4e into elastic:master Jul 29, 2020
imotov added a commit to imotov/elasticsearch that referenced this pull request Jul 29, 2020
@imotov
Streamline GeoJSON to map serialization (elastic#60413)
98abe6b 
Optimizes GeoJSON to map serialization when retrieving spatial data through
`fields`.

Closes elastic#60259
imotov added a commit that referenced this pull request Jul 29, 2020
@imotov
Streamline GeoJSON to map serialization (#60413) (#60429)
00a1949 
Optimizes GeoJSON to map serialization when retrieving spatial data through
fields.

Closes #60259
@imotov imotov deleted the issue-60259-optimize-json-to-map-serialization branch July 29, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtibshirani jtibshirani jtibshirani approved these changes

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring :Search/Search Search-related issues that do not fall into other categories Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Meta label for search team v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streamline serialization when retrieving spatial data through fields.
4 participants
@imotov @elasticmachine @jtibshirani @jakelandis