Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to AdoptOpenJDK for bundled jdk #64026

Closed
rjernst opened this issue Oct 21, 2020 · 3 comments · Fixed by #64253
Closed

Switch back to AdoptOpenJDK for bundled jdk #64026

rjernst opened this issue Oct 21, 2020 · 3 comments · Fixed by #64253
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team

Comments

@rjernst
Copy link
Member

rjernst commented Oct 21, 2020

We recently switched the bundled jdk back to Oracle, to maintain support for CentOS 6/OEL 6/RHEL 6, which was broken with jdk 15 of adoptopenjdk (adoptium/temurin-build#2097). While this worked to get jdk 15 working on those older platforms, this causes an issue with homebrew:

==> find /usr/local/Cellar/elasticsearch-full/7.9.3/libexec/jdk.app/Contents/Home/bin -type f -exec
Error: Failed changing dylib ID of /usr/local/Cellar/elasticsearch-full/7.9.3/libexec/jdk.app/Contents/Home/lib/libnet.dylib
  from @rpath/libnet.dylib
    to /usr/local/opt/elasticsearch-full/libexec/jdk.app/Contents/Home/lib/libnet.dylib
Error: Failed to fix install linkage
The formula built, but you may encounter issues using it or linking other
formulae against it.

It is unclear how this issue can be fixed without recompiling the jdk. Fortunately the original issue upstream in AdoptOpenJDK has been fixed, and the 15.0.1 release should again support RHEL 6 and friends. We should switch back to adoptopenjdk, since we know it does not have this issue with homebrew.
@rjernst rjernst added the :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts label Oct 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Packaging)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 21, 2020
@sweikenb
Copy link

Running into the same issue.

@aahlenst
Copy link

AdoptOpenJDK member here... 15.0.1 is out. Sorry for the problems with CentOS 6. We plan to keep glibc 2.12 support around as long as it is supported by OpenJDK and technically possible. If we ever cause problems again, please make some noise. I almost missed the issue reference.

rjernst added a commit to rjernst/elasticsearch that referenced this issue Oct 27, 2020
@rjernst
Upgrade bundled jdk to 15.0.1 and switch back to Oracle
c9d451d 
This commit updates the bundled jdk to 15.0.1, and at the same time once
again switches the bundled jdk back to adoptopenjdk, which has fixed
their build problem and regained support for glibc 2.12.

closes elastic#64026
@rjernst rjernst mentioned this issue Oct 27, 2020
Merged
rjernst added a commit that referenced this issue Oct 29, 2020
@rjernst
Upgrade bundled jdk to 15.0.1 and switch back to Oracle (#64253)
29a66a7 
This commit updates the bundled jdk to 15.0.1, and at the same time once
again switches the bundled jdk back to adoptopenjdk, which has fixed
their build problem and regained support for glibc 2.12.

closes #64026
rjernst added a commit that referenced this issue Oct 29, 2020
@rjernst
Upgrade bundled jdk to 15.0.1 and switch back to Oracle (#64253)
6127421 
This commit updates the bundled jdk to 15.0.1, and at the same time once
again switches the bundled jdk back to adoptopenjdk, which has fixed
their build problem and regained support for glibc 2.12.

closes #64026
rjernst added a commit that referenced this issue Oct 29, 2020
@rjernst
Upgrade bundled jdk to 15.0.1 and switch back to Oracle (#64253)
b1ba274 
This commit updates the bundled jdk to 15.0.1, and at the same time once
again switches the bundled jdk back to adoptopenjdk, which has fixed
their build problem and regained support for glibc 2.12.

closes #64026
rjernst added a commit that referenced this issue Oct 29, 2020
@rjernst
Upgrade bundled jdk to 15.0.1 and switch back to AdoptOpenJDK
46d8c84 
This commit updates the bundled jdk to 15.0.1, and at the same time once
again switches the bundled jdk back to adoptopenjdk, which has fixed
their build problem and regained support for glibc 2.12.

closes #64026
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
@andsel andsel mentioned this issue Feb 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade bundled jdk to 15.0.1 and switch back to AdoptOpenJDK rjernst/elasticsearch
5 participants
@aahlenst @rjernst @sweikenb @mark-vieira @elasticmachine