Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoLineAggregator test failures #65473

Closed
talevy opened this issue Nov 25, 2020 · 1 comment · Fixed by #65521
Closed

GeoLineAggregator test failures #65473

talevy opened this issue Nov 25, 2020 · 1 comment · Fixed by #65521
Assignees
@talevy
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@talevy
Copy link
Contributor

talevy commented Nov 25, 2020

Some GeoLine Index out of bound errors are occurring in random situations. Likely a real bug in the code.

Build scan:

https://gradle-enterprise.elastic.co/s/dwlcnado6vcbs/tests/:x-pack:plugin:spatial:yamlRestTest/org.elasticsearch.xpack.spatial.SpatialClientYamlTestSuiteIT/test%20%7Byaml=%2F60_geo_line%2FTest%20geo_line%20aggregation%20on%20geo%20points%7D

Repro line:

./gradlew ':x-pack:plugin:spatial:yamlRestTest' --tests "org.elasticsearch.xpack.spatial.SpatialClientYamlTestSuiteIT.test {yaml=/60_geo_line/Test geo_line aggregation on geo points}" -Dtests.seed=F6F1494C04EE888C -Dtests.security.manager=true -Dtests.locale=pt-BR -Dtests.timezone=Africa/Luanda -Druntime.java=15

Reproduces locally?:

yes

Applicable branches:

7.x and master
@talevy talevy added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Nov 25, 2020
@talevy talevy self-assigned this Nov 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@talevy talevy mentioned this issue Nov 25, 2020
Merged
@cbuescher cbuescher mentioned this issue Nov 25, 2020
Closed
talevy added a commit to talevy/elasticsearch that referenced this issue Nov 25, 2020
@talevy
Fixes GeoLineAggregator bugs
7286b2e 
This commit unmutes and fixes tests around some GeoLineAggregator edge
cases.

- MergedGeoLines had a silly bug where it was accepting InternalGeoLines
  that were empty
- "complete" is measured by the heap-mode of the BucketedSort, which is a problem
  since if the length of the data equals the max-size, then it is difficult to know
  whether any values were discarded.
- GeoLineBucketSort had an array-resizing bug s/>/>=

Fixes elastic#65473.
@talevy talevy mentioned this issue Nov 25, 2020
Merged
talevy added a commit that referenced this issue Dec 2, 2020
@talevy
Fixes GeoLineAggregator bugs (#65521)
e4e8905 
This commit unmutes and fixes tests around some GeoLineAggregator edge
cases.

- MergedGeoLines had a silly bug where it was accepting InternalGeoLines
  that were empty
- "complete" is measured by the heap-mode of the BucketedSort, which is a problem
  since if the length of the data equals the max-size, then it is difficult to know
  whether any values were discarded.
- GeoLineBucketSort had an array-resizing bug s/>/>=

Fixes #65473.
talevy added a commit that referenced this issue Dec 2, 2020
@talevy
Fixes GeoLineAggregator bugs (#65521)
bbcec45 
This commit unmutes and fixes tests around some GeoLineAggregator edge
cases.

- MergedGeoLines had a silly bug where it was accepting InternalGeoLines
  that were empty
- "complete" is measured by the heap-mode of the BucketedSort, which is a problem
  since if the length of the data equals the max-size, then it is difficult to know
  whether any values were discarded.
- GeoLineBucketSort had an array-resizing bug s/>/>=

Fixes #65473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talevy talevy

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes GeoLineAggregator bugs talevy/elasticsearch
2 participants
@talevy @elasticmachine