Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BulkProcessor creates multiple scheduler threads with identical names #68470

Closed
DaveCTurner opened this issue Feb 3, 2021 · 1 comment · Fixed by #69432
Closed

BulkProcessor creates multiple scheduler threads with identical names #68470

DaveCTurner opened this issue Feb 3, 2021 · 1 comment · Fixed by #69432
Labels
>bug Team:Data Management Meta label for data/management team

Comments

@DaveCTurner
Copy link
Contributor

Elasticsearch version (bin/elasticsearch --version): 7.10.2 (and others)

Plugins installed: N/A

JVM version (java -version): N/A

OS version (uname -a if on a Unix-like system): N/A

Description of the problem including expected versus actual behavior:

BulkProcessor#builder(BiConsumer, Listener) constructs two scheduler threads, both called [node-name][scheduler][T#1], which is also the name of the node's main scheduler thread. This is confusing, it would be preferable if these threads all had different names.

Steps to reproduce:

Do something that involves the ILM history store, which uses BulkProcessor#builder(BiConsumer, Listener), and then take a thread dump of the node.

Provide logs (if relevant):

Not relevant.
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Feb 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Feb 23, 2021
@DaveCTurner
Unique names for bulk processor scheduler threads
adc8ff4 
Today every `BulkProcessor` creates two scheduler threads, both called
`[node-name][scheduler][T#1]`, which is also the name of the main
scheduler thread for the node. The duplicated thread names make it
harder to interpret a thread dump.

This commit makes the names of these threads distinct.

Closes elastic#68470
@DaveCTurner DaveCTurner mentioned this issue Feb 23, 2021
Merged
DaveCTurner added a commit that referenced this issue Mar 4, 2021
@DaveCTurner
Unique names for bulk processor scheduler threads (#69432)
864ff66 
Today every `BulkProcessor` creates two scheduler threads, both called
`[node-name][scheduler][T#1]`, which is also the name of the main
scheduler thread for the node. The duplicated thread names make it
harder to interpret a thread dump.

This commit makes the names of these threads distinct.

Closes #68470
DaveCTurner added a commit that referenced this issue Mar 4, 2021
@DaveCTurner
Unique names for bulk processor scheduler threads (#69432)
95dba0d 
Today every `BulkProcessor` creates two scheduler threads, both called
`[node-name][scheduler][T#1]`, which is also the name of the main
scheduler thread for the node. The duplicated thread names make it
harder to interpret a thread dump.

This commit makes the names of these threads distinct.

Closes #68470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unique names for bulk processor scheduler threads DaveCTurner/elasticsearch
2 participants
@DaveCTurner @elasticmachine