-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If _parent field points to a non existing parent type, then skip the has_parent query/filter #7362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the extraction of the parent filter gets a bit more complicated, maybe this should be extracted to a utility method to make sure it doesn't get out-of-sync between the query and the filter? |
@jpountz good point, I'll change that. |
@jpountz Updated the pr, and common parsing logic has been moved to a static helper method. |
LGTM |
martijnvg
changed the title
If _parent field points to a non existing parent type, then skip the has_child query/filter
If _parent field points to a non existing parent type, then skip the has_parent query/filter
Aug 27, 2014
martijnvg
force-pushed
the
bugs/has_child_parser_npe
branch
from
August 27, 2014 07:00
5889e5c
to
fb6914b
Compare
…then skip the has_parent query/filter Closes elastic#7362 Closes elastic#7349
martijnvg
force-pushed
the
bugs/has_child_parser_npe
branch
from
August 27, 2014 07:01
fb6914b
to
d414d89
Compare
spinscale
changed the title
If _parent field points to a non existing parent type, then skip the has_parent query/filter
Parent/Child: If _parent field points to a non existing parent type, then skip the has_parent query/filter
Aug 27, 2014
This was referenced Oct 8, 2014
clintongormley
changed the title
Parent/Child: If _parent field points to a non existing parent type, then skip the has_parent query/filter
If _parent field points to a non existing parent type, then skip the has_parent query/filter
Jun 7, 2015
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…then skip the has_parent query/filter Closes elastic#7362 Closes elastic#7349
clintongormley
added
:Search/Search
Search-related issues that do not fall into other categories
and removed
:Parent/Child
labels
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Search/Search
Search-related issues that do not fall into other categories
v1.3.3
v1.4.0.Beta1
v2.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #7349