ban Throwable.toString() and Throwable.getMessage()

[rmuir]

This way, we never have "partial exceptions" with incomplete information anywhere.

I havent yet fixed any of the 97 violations in question.

Errors in the branch look like this:
[ERROR] Forbidden method invocation: java.lang.Throwable#getMessage() [Use ExceptionsHelper.stackTrace(Throwable) instead]
[ERROR] in org.elasticsearch.index.snapshots.blobstore.BlobStoreIndexShardRepository (BlobStoreIndexShardRepository.java:152)

[javanna]

+1

[nik9000]

+1
I hate these.

On Fri, Mar 6, 2015 at 12:33 PM, Luca Cavanna notifications@github.com
wrote:

+1

—
Reply to this email directly or view it on GitHub
#10021 (comment)
.

[uschindler]

Very nice :)

+1

[rjernst]

+1

FWIW, the main place I see exceptions being simplified is in SearchShardFailure, in the constructor it calls ExceptionsHelper.detailedMessage. This thing loses the stack trace.

[s1monw]

lets fix them +1 rob, we can also open a public branch for this...

[s1monw]

@rmuir do you wanna open a public branch and we fix it there?

[MaineC]

I spent some time the past few days looking at where we actually use .getMessage() in the code:

• There's some occurrences due to the fact that exceptions we created do not support a Exception(Throwable cause) constructor but always request a message. Can easily be fixed by either adding the simpler constructor or using a more meaningful message.
• There's simple things like creating log messages. I suppose these can simply be switched to .stackTrace(...)
• There's instances where from a coarse scan it looks like instances of serialising failures, would have to dig deeper to see what exactly is going on there.
• Then there's a handful of trickier instances like e.g. parsing the message to figure out what really went wrong in a certain call.

Caveat: I was starting to make changes in a local bug fix branch a bit too quickly resulting in a) a pretty large diff with changes related to all of the above mixed together, b) breaking two unit tests as a result. Trying to concentrate on the first bullet point for a cleaner approach first.

[dakrone]

Closing this for now, someone can base work off of it if desired in the future.