Translog: make sure stats's op count and size are in sync #10041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During translog flush there is a very small window where translog stats reports can be inconsistent.
|
LGTM |
| @@ -466,6 +466,11 @@ public void syncOnEachOperation(boolean syncOnEachOperation) { | |||
|
|
|||
| @Override | |||
| public TranslogStats stats() { | |||
| return new TranslogStats(estimatedNumberOfOperations(), translogSizeInBytes()); | |||
| FsTranslogFile current1 = this.current; | |||
There was a problem hiding this comment.
can we name this just current I think this 1 is not necessary!
There was a problem hiding this comment.
fair enough. I used the same pattern used in the file in other places.
|
left one comment |
bleskes
added a commit
that referenced
this pull request
Mar 13, 2015
During translog flush there is a very small window where translog stats reports can be inconsistent. Closes #10041
bleskes
added a commit
that referenced
this pull request
Mar 13, 2015
During translog flush there is a very small window where translog stats reports can be inconsistent. Closes #10041
clintongormley
added
:Data Management/Stats
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
During translog flush there is a very small window where translog stats reports can be inconsistent. Closes elastic#10041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During translog flush there is a very small window where translog stats reports can be inconsistent.
Example: