Fix NullPointerException in RotableSecret #100779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two things: 1) RotatableSecret#matches could throw a NullPointerException when the current secret is null but the prior secret is not. 2) RotatableSecret#checkExpired would not expire a prior secret when checking the same millisecond the prior secret was due to expire. Both of these would cause intermittent test failures, the first based on randomization
gwbrown
added
>bug
:Security/Security
|
Hi @gwbrown, I've created a changelog YAML for you. |
|
Pinging @elastic/es-security (Team:Security) |
jakelandis
reviewed
Oct 12, 2023
docs/changelog/100779.yaml
Outdated
| @@ -0,0 +1,6 @@ | |||
| pr: 100779 | |||
| summary: Fix bugs causing `RotatableSecretTests#testBasicRotation` to fail | |||
There was a problem hiding this comment.
nit: update summary to 'Fix NullPointerException in RotableSecret'
jakelandis
approved these changes
Oct 12, 2023
gwbrown
changed the title
gwbrown
added
the
auto-backport-and-merge
|
@elasticmachine run elasticsearch-ci/part-1 |
💚 Backport successful
|
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Oct 13, 2023
This commit fixes two things: 1) RotatableSecret#matches could throw a NullPointerException when the current secret is null but the prior secret is not. 2) RotatableSecret#checkExpired would not expire a prior secret when checking the same millisecond the prior secret was due to expire. Both of these would cause intermittent test failures, the first based on randomization, the second based on timing.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 13, 2023
This commit fixes two things: 1) RotatableSecret#matches could throw a NullPointerException when the current secret is null but the prior secret is not. 2) RotatableSecret#checkExpired would not expire a prior secret when checking the same millisecond the prior secret was due to expire. Both of these would cause intermittent test failures, the first based on randomization, the second based on timing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two things:
RotatableSecret#matchescould throw aNullPointerExceptionwhen the current secret is null but the prior secret is not.RotatableSecret#checkExpiredwould not expire a prior secret when checking the same millisecond the prior secret was due to expire.Both of these would cause intermittent test failures, the first based on randomization and the second based on timing.
Fixes #99759