Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullPointerException in RotableSecret #100779

Merged
merged 3 commits into from Oct 13, 2023
Merged

Fix NullPointerException in RotableSecret #100779

merged 3 commits into from Oct 13, 2023

Commits on Oct 12, 2023

  1. Fix bugs causing RotatableSecretTests#testBasicRotation to fail 

    This commit fixes two things:
1) RotatableSecret#matches could throw a NullPointerException when the current secret is null but the prior secret is not.
2) RotatableSecret#checkExpired would not expire a prior secret when checking the same millisecond the prior secret was due to expire.

Both of these would cause intermittent test failures, the first based on randomization
    @gwbrown
    gwbrown committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7ff8d0c View commit details
    Browse the repository at this point in the history

  2. Update docs/changelog/100779.yaml

    @gwbrown
    gwbrown committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c872f41 View commit details
    Browse the repository at this point in the history

  3. Fix summary

    @gwbrown
    gwbrown committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c025b32 View commit details
    Browse the repository at this point in the history