Revert non-semantic NodeInfo #102636
Merged
Revert non-semantic NodeInfo #102636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>regression
:Core/Infra/Core
|
Hi @ldematte, I've created a changelog YAML for you. |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @ldematte, I've created a changelog YAML for you. |
thecoop
approved these changes
Nov 27, 2023
thecoop
reviewed
Nov 27, 2023
| @@ -117,7 +118,8 @@ public NodeInfo info( | |||
| boolean indices | |||
| ) { | |||
| return new NodeInfo( | |||
| Build.current().version(), | |||
| // TODO: revert to Build.current().version() when Kibana is updated | |||
There was a problem hiding this comment.
Do we have a ticket to track this yet?
timgrein
pushed a commit
to timgrein/elasticsearch
that referenced
this pull request
Nov 30, 2023
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 20, 2024
Kibana has updated its codebase to handle non-semver (elastic/kibana#172093), so we can now safely reintroduce our change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal change to revert #100746 (a full revert was not possible due to TransportVersion change).
Reason: it appears that serverless Kibana is still relying on semantic versions.