Moving NodeInfo internal version storage to String #100746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
ldematte
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
changed the title
Version parsing compatible with Build.version() - snapshot builds and non-semantic versions. Provisional solution before Feature API
|
This change breaks many tests that rely on NodeInfo version string to be parseable to a Version (via the |
rjernst
reviewed
Oct 12, 2023
server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/NodeInfo.java
Outdated
Show resolved
Hide resolved
ldematte
force-pushed
the
nodeinfo-version-string-external
branch
from
99031ff to
c096ce9
Compare
This was referenced Oct 17, 2023
ldematte
added
test-update-serverless
test-release
|
@elasticmachine rerun elasticsearch-ci/part-2 |
|
@elasticmachine rerun elasticsearch-ci/check-serverless-submodule |
timgrein
pushed a commit
to timgrein/elasticsearch
that referenced
this pull request
Nov 30, 2023
NodeInfo version as string. Moving from Version to Build.version(), which means also non-semantic versions. Particular care was needed for ESRestTestCase Version parsing, to make it work in a serverless environment, removing Version whenever possible and adding proper fallbacks when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #100673 and will be updated with that before merging