Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save allocating enum values array in two hot spots #104952

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Save allocating enum values array in two hot spots #104952

merged 1 commit into from
Jan 31, 2024
+12 −3

Commits on Jan 30, 2024

  1. Save allocating enum values array in two hot spots 

    Our readEnum code instantiates/clones enum value arrays on read.
Normally, this doesn't matter much but the two spots adjusted here are
visibly hot during bulk indexing, causing GBs of allocations during e.g.
the http_logs indexing run.
    @original-brownbear
    original-brownbear committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1107c5e View commit details
    Browse the repository at this point in the history