[Transform] Make use of delegateFailureAndWrap #106034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring to a later pattern of ActionListener, reducing memory footprint and removing some redudant lines of code.
prwhelan
added
>non-issue
:ml/Transform
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
reviewed
Mar 6, 2024
| unusedValidationResponse -> putTransform(request, listener), | ||
| listener::onFailure | ||
| ActionListener<ValidateTransformAction.Response> validateTransformListener = listener.delegateFailureAndWrap( | ||
| (paramListener, unused) -> putTransform(request, paramListener) |
There was a problem hiding this comment.
We should also settle on the naming for the lambda parameter, here paramListener. If you look at the recent refactoring PR (#105907), we chose l as the name, although I'm fine with any other name, just please keep it consistent throughout the file.
There was a problem hiding this comment.
Went with l since that is what the previous PR did (I thought it was delegate but was mistaken)
| transformConfigManager.putTransformConfiguration(config, putTransformConfigurationListener); | ||
| var config = request.getConfig(); | ||
| transformConfigManager.putTransformConfiguration(config, listener.delegateFailureAndWrap((paramListener, unused) -> { | ||
| var configId = config.getId(); |
There was a problem hiding this comment.
We usually use transformId for this. Could you use this name here too?
|
@elasticmachine update branch |
fang-xing-esql
pushed a commit
to fang-xing-esql/Elasticsearch
that referenced
this pull request
Mar 8, 2024
* [Transform] Make use of delegateFailureAndWrap Refactoring to a later pattern of ActionListener, reducing memory footprint and removing some redudant lines of code. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to a later pattern of ActionListener, reducing memory footprint and removing some redudant lines of code.