Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplication around transport code in IndexBasedTransformConfigManager #105907

Merged

Conversation

original-brownbear
Copy link
Member

Drying up the logic in this class and making use of
delegateAndWrap in an effort to narrow down possible sources for the
remaining very rare leaks we observe around SearchResponse.

…ager

Drying up the logic in this class further and making use of
`delegateAndWrap` in an effort to narrow down possible sources for the
remaining very rare leaks we observe around `SearchResponse`.
This reverts commit a01f84f.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@przemekwitek przemekwitek self-requested a review March 5, 2024 12:23
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

Thanks @przemekwitek !

@original-brownbear original-brownbear merged commit f468024 into elastic:main Mar 6, 2024
14 checks passed
@original-brownbear original-brownbear deleted the fix-duplication-transform branch March 6, 2024 13:30
fang-xing-esql pushed a commit to fang-xing-esql/Elasticsearch that referenced this pull request Mar 8, 2024
…ager (elastic#105907)

Drying up the logic in this class further and making use of
`delegateAndWrap` in an effort to narrow down possible sources for the
remaining very rare leaks we observe around `SearchResponse`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform >non-issue Team:ML Meta label for the ML team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants