-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplication around transport code in IndexBasedTransformConfigManager #105907
Merged
original-brownbear
merged 5 commits into
elastic:main
from
original-brownbear:fix-duplication-transform
Mar 6, 2024
Merged
Fix duplication around transport code in IndexBasedTransformConfigManager #105907
original-brownbear
merged 5 commits into
elastic:main
from
original-brownbear:fix-duplication-transform
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ager Drying up the logic in this class further and making use of `delegateAndWrap` in an effort to narrow down possible sources for the remaining very rare leaks we observe around `SearchResponse`.
This reverts commit a01f84f.
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
reviewed
Mar 5, 2024
...ain/java/org/elasticsearch/xpack/transform/persistence/IndexBasedTransformConfigManager.java
Show resolved
Hide resolved
przemekwitek
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @przemekwitek ! |
fang-xing-esql
pushed a commit
to fang-xing-esql/Elasticsearch
that referenced
this pull request
Mar 8, 2024
…ager (elastic#105907) Drying up the logic in this class further and making use of `delegateAndWrap` in an effort to narrow down possible sources for the remaining very rare leaks we observe around `SearchResponse`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drying up the logic in this class and making use of
delegateAndWrap
in an effort to narrow down possible sources for theremaining very rare leaks we observe around
SearchResponse
.