[ES|QL] Add mv_sort #106095
Merged
[ES|QL] Add mv_sort #106095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
requested changes
Mar 7, 2024
...pute/src/main/generated-src/org/elasticsearch/compute/operator/MultivalueDedupeBytesRef.java
Outdated
Show resolved
Hide resolved
...pute/src/main/generated-src/org/elasticsearch/compute/operator/MultivalueDedupeBytesRef.java
Outdated
Show resolved
Hide resolved
...pute/src/main/generated-src/org/elasticsearch/compute/operator/MultivalueDedupeBytesRef.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvSort.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvSortTests.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvSortTests.java
Show resolved
Hide resolved
Thanks for reviewing, the input to sortToBlock that indicates the sort order is converted to a boolean, if there is a better way to do it, any suggestion is welcome! |
nik9000
requested changes
Mar 11, 2024
There was a problem hiding this comment.
I left a small thing about the stringtemplate stuff and medium sized thing around the boolean translation. I think there's a better way to do it. The way you are doing it I think is fairly confusing. I had a to read it a few times and I think it's possible it'll do unexpected things.
...gin/esql/compute/src/main/java/org/elasticsearch/compute/operator/X-MultivalueDedupe.java.st
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvSort.java
Outdated
Show resolved
Hide resolved
|
A subtask of #105322 . |
nik9000
approved these changes
Mar 12, 2024
...gin/esql/compute/src/main/java/org/elasticsearch/compute/operator/X-MultivalueDedupe.java.st
Show resolved
Hide resolved
...n/esql/compute/src/main/java/org/elasticsearch/compute/operator/MultivalueDedupeBoolean.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvSort.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvSort.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvSort.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvSortTests.java
Show resolved
Hide resolved
|
good luck with all the merges. |
Thanks for reviewing Nik! All of the comments are addressed. |
nik9000
approved these changes
Mar 13, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mv_sort sorts a multivalued field in ascending or descending order. If an order is not specified, the default is in ascending order.