Remove pointless AbstractClient indirection
#108002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the removal of the transport client `o.e.c.i.Client` has exactly one implementation, `o.e.c.i.s.AbstractClient`, which essentially just defines how each method maps onto a transport action. Likewise for `AdminClient`, `ClusterAdminClient` and `IndicesAdminClient`. This commit inlines these implementations into the parent interfaces.
DaveCTurner
added
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
This was mechanical but unfortunately that process seems to have lost the Javadocs and reordered everything. I'm not sure this matters, the order wasn't important and there was essentially nothing useful in those comments anyway. |
|
Ugh TIL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the removal of the transport client
o.e.c.i.Clienthas exactlyone implementation,
o.e.c.i.s.AbstractClient, which essentially justdefines how each method maps onto a transport action. Likewise for
AdminClient,ClusterAdminClientandIndicesAdminClient. Thiscommit inlines these implementations into the parent interfaces.