Remove unneeded client subinterfaces #108052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
:Core/Infra/Transport API
Since the removal of the transport client these interfaces all have exactly one implementation. There's no need for the extra layer of abstraction any more so this commit removes it.
DaveCTurner
force-pushed
the
2024/04/30/pointless-client-subinterfaces
branch
2 times, most recently
from
3403183
to
bb461dc
Compare
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
This was mechanical but unfortunately that process seems to have lost the Javadocs and reordered everything. I'm not sure this matters, the order wasn't important and there was essentially nothing useful in those comments anyway. |
| */ | ||
| ClusterAdminClient cluster(); | ||
| protected final ClusterAdminClient clusterAdmin; | ||
| protected final IndicesAdminClient indicesAdmin; |
There was a problem hiding this comment.
I think this could be a record. Do we rely on those fields being protected in lots of plases?
There was a problem hiding this comment.
There's mocks and other reflection-based stuff in tests that get in the way of tightening these things down. Possibly we could make them private but I'm hoping this stuff can all just go away soon so I don't think it's worth polishing this too much.
idegtiarenko
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the removal of the transport client these interfaces all have
exactly one implementation. There's no need for the extra layer of
abstraction any more so this commit removes it.