Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen numeric counter types #108036

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Widen numeric counter types #108036

merged 1 commit into from
Apr 29, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Apr 29, 2024

We should widen the numeric root types before converting them into counter types.

Relates #107877

@dnhatn dnhatn changed the title Handle unsupported counter types Widen numeric counter types Apr 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@dnhatn
Copy link
Member Author

dnhatn commented Apr 29, 2024

Thanks Nik!

@dnhatn dnhatn merged commit b6ccb84 into elastic:main Apr 29, 2024
15 checks passed
@dnhatn dnhatn deleted the more-counter-type branch April 29, 2024 19:25
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx Nhat! lgtm2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants