Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continent_code support to the geoip processor #108780

Merged
merged 4 commits into from
May 17, 2024

Conversation

joegallo
Copy link
Contributor

Closes #85820

Adds continent_code to the supported fields for the Country, City, and Enterprise databases; but does not add it to the default fields for any of those databases.

@joegallo joegallo added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v8.15.0 labels May 17, 2024
@joegallo joegallo requested a review from masseyke May 17, 2024 14:34
Copy link

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @joegallo, I've created a changelog YAML for you.

@joegallo joegallo requested a review from nielsbauman May 17, 2024 14:55
Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but bear in mind that I'm not that familiar with GeoIP, so might not be unwise to wait for a second (or well third) pair of eyes.,

@joegallo joegallo merged commit e1b2b59 into elastic:main May 17, 2024
15 checks passed
@joegallo joegallo deleted the ingest-geoip-processor-continent-code branch May 17, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add property to GeoIp processor continent_code.
4 participants