Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Print out recovery translog state #108858

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

arteam
Copy link
Contributor

@arteam arteam commented May 21, 2024

The test in #108037 failed only once in 3 months, it never reproduces on my machine. Let's print the state of translog before verifying, so we have more debug information about it if the failure ever happens again.

See #108037

The test in #108037 failed only once in 3 months, it never reproduces on my machine.
Let's print the state of translog before verifying, so we have more debug information
about it if the failure ever happens again.

See #108037
@arteam arteam added >test Issues or PRs that are addressing/adding tests :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) labels May 21, 2024
@elasticsearchmachine elasticsearchmachine added v8.15.0 Team:Distributed Meta label for distributed team labels May 21, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@arteam arteam changed the title Print out recovery translog state [test] Print out recovery translog state May 21, 2024
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing synchronization, otherwise LGTM

…ryState.java

Co-authored-by: David Turner <david.turner@elastic.co>
@arteam arteam merged commit 1148861 into main May 22, 2024
16 checks passed
@arteam arteam deleted the add-recovery-translog-logs branch May 22, 2024 12:05
@arteam
Copy link
Contributor Author

arteam commented May 22, 2024

Thank you David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants