Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up ThreadPool#assertCurrentThreadPool #108943

Conversation

DaveCTurner
Copy link
Contributor

As suggested in #108934, we can extract the exact executor name from the
thread name with some simple string manipulations. Using this utility,
this commit tightens up the existing assertions about the current
executor.

Co-authored-by: Henning Andersen henning.andersen@elastic.co

As suggested in elastic#108934, we can extract the exact executor name from the
thread name with some simple string manipulations. Using this utility,
this commit tightens up the existing assertions about the current
executor.

Co-authored-by: Henning Andersen <henning.andersen@elastic.co>
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. v8.15.0 labels May 23, 2024
@DaveCTurner DaveCTurner requested a review from a team as a code owner May 23, 2024 10:20
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label May 23, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DaveCTurner DaveCTurner added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 23, 2024
@elasticsearchmachine elasticsearchmachine merged commit 331b78f into elastic:main May 23, 2024
15 checks passed
@DaveCTurner DaveCTurner deleted the 2024/05/23/EsExecutors-executorName branch May 23, 2024 13:43
@DaveCTurner DaveCTurner restored the 2024/05/23/EsExecutors-executorName branch June 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants