Add error indexes to all datetime formatter tests #108944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
Team:Core/Infra
rjernst
reviewed
May 23, 2024
server/src/main/java/org/elasticsearch/common/time/DateFormatters.java
Outdated
Show resolved
Hide resolved
rjernst
reviewed
May 23, 2024
| // sometimes use the java.time date formatters | ||
| // we can't use randomBoolean here, the random context isn't set properly | ||
| // so read it directly from the test seed in an unfortunately hacky way | ||
| String testSeed = System.getProperty("tests.seed", "0"); |
There was a problem hiding this comment.
The seed should already be available in this test context? Just use randomBoolean()
There was a problem hiding this comment.
Unfortunately not, that throws in RandomizedContext.context saying there's no context info for the thread
There was a problem hiding this comment.
Ah, I think this is due to limitations in JUnit 4. Because the Runner is passed an already initialized suite Class, so this static init runs before the Runner can actually setup the context.
|
@elasticmachine update branch |
rjernst
approved these changes
May 24, 2024
| String testSeed = System.getProperty("tests.seed", "0"); | ||
| boolean firstBit = (Integer.parseInt(testSeed.substring(testSeed.length() - 1), 16) & 1) == 1; | ||
| if (firstBit) { | ||
| System.setProperty("es.datetime.java_time_parsers", "true"); |
There was a problem hiding this comment.
nit: it would be good to cover all 3 cases, true, false and not present?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we check the error index in all dateformatter parse exception tests. As part of this, we need to add a hook enabling us to test both ISO and java.time parser implementations in tests