Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility for asserting listeners are completed #109325
Add utility for asserting listeners are completed #109325
Changes from 15 commits
984e2fd
1b54b82
c94c829
99d0e16
323b6f6
a88ce9f
1e84c2b
bf99ff0
9171a55
b90f16b
4f0e438
83f3145
3507494
890df5d
df408e4
94ab0e9
3fbd9f5
628034f
2bc3635
29947e5
ad3a53c
884238d
344477f
3372f44
cbb962e
076ed95
07f7127
e45718b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a shortcoming, if the listener is something that is retained in some other way (such as the listener returned by
noop()
) the detection won't work because it'll never become unreachable. I'm not sure how common this is though. We could insert another pass-through delegate in the chain that isn't referenced from anywhere (and register that with the cleaner) to make it more robust, but that would allocate an additional object for what might be a rare/unimportant edge-case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat.