Remove the MLT API #11003
Closed
Remove the MLT API #11003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the More Like This API, users should now use the More Like This query. The MLT API tests were converted to their query equivalent. Also some clean ups in MLT tests.
| @@ -1,32 +0,0 @@ | |||
| [[search-more-like-this]] | |||
There was a problem hiding this comment.
I think you also need to remove the include from docs/reference/search.asciidoc for the docs to build?
|
LGTM I like the diff stats :) |
|
👊 nice! |
| @@ -0,0 +1,10 @@ | |||
| [[breaking-changes-1.6]] | |||
There was a problem hiding this comment.
wondering, shouldn't this file go in as part of the deprecation PR instead of this one? Also, did we ever keep track of deprecations in migrate* files? this is not really a breaking change for 1.6 and it might create the expectation that for each deprecation we have an entry in the migrate document, which I think we haven't.
There was a problem hiding this comment.
I was wondering about that too. @clintongormley Should we record deprecations in migrate* files?
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the More Like This API, users should now use the More Like This query.
The MLT API tests were converted to their query equivalent. Also some clean
ups in MLT tests.
Closes #10736