Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the MLT API #11003

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/reference/migration/index.asciidoc
Expand Up @@ -19,7 +19,8 @@ See <<setup-upgrade>> for more info.

include::migrate_2_0.asciidoc[]

include::migrate_1_6.asciidoc[]

include::migrate_1_4.asciidoc[]

include::migrate_1_0.asciidoc[]

10 changes: 10 additions & 0 deletions docs/reference/migration/migrate_1_6.asciidoc
@@ -0,0 +1,10 @@
[[breaking-changes-1.6]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering, shouldn't this file go in as part of the deprecation PR instead of this one? Also, did we ever keep track of deprecations in migrate* files? this is not really a breaking change for 1.6 and it might create the expectation that for each deprecation we have an entry in the migrate document, which I think we haven't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about that too. @clintongormley Should we record deprecations in migrate* files?

== Breaking changes in 1.6

This section discusses the changes that you need to be aware of when migrating
your application from Elasticsearch 1.x to Elasticsearch 1.6.

[float]
=== More Like This API

The More Like This API query has been deprecated and will be removed in 2.0. Instead use the <<query-dsl-mlt-query, More Like This Query>>.
6 changes: 3 additions & 3 deletions docs/reference/migration/migrate_2_0.asciidoc
Expand Up @@ -24,10 +24,10 @@ The following deprecated methods have been removed:

Partial fields were deprecated since 1.0.0beta1 in favor of <<search-request-source-filtering,source filtering>>.

=== More Like This Field
=== More Like This

The More Like This Field query has been removed in favor of the <<query-dsl-mlt-query, More Like This Query>>
restrained set to a specific `field`.
The More Like This API and the More Like This Field query have been removed in
favor of the <<query-dsl-mlt-query, More Like This Query>>.

=== Routing

Expand Down
32 changes: 0 additions & 32 deletions docs/reference/search/more-like-this.asciidoc

This file was deleted.

104 changes: 0 additions & 104 deletions rest-api-spec/api/mlt.json

This file was deleted.

17 changes: 11 additions & 6 deletions rest-api-spec/test/mlt/10_basic.yaml
Expand Up @@ -30,11 +30,16 @@
wait_for_status: green

- do:
mlt:
index: test_1
type: test
id: 1
mlt_fields: title

search:
index: test_1
type: test
body:
query:
more_like_this:
like:
-
_id: 1
fields: title

- match: {hits.total: 0}

3 changes: 0 additions & 3 deletions src/main/java/org/elasticsearch/action/ActionModule.java
Expand Up @@ -139,8 +139,6 @@
import org.elasticsearch.action.indexedscripts.get.TransportGetIndexedScriptAction;
import org.elasticsearch.action.indexedscripts.put.PutIndexedScriptAction;
import org.elasticsearch.action.indexedscripts.put.TransportPutIndexedScriptAction;
import org.elasticsearch.action.mlt.MoreLikeThisAction;
import org.elasticsearch.action.mlt.TransportMoreLikeThisAction;
import org.elasticsearch.action.percolate.*;
import org.elasticsearch.action.search.*;
import org.elasticsearch.action.search.type.*;
Expand Down Expand Up @@ -293,7 +291,6 @@ protected void configure() {
TransportSearchScrollQueryAndFetchAction.class
);
registerAction(MultiSearchAction.INSTANCE, TransportMultiSearchAction.class);
registerAction(MoreLikeThisAction.INSTANCE, TransportMoreLikeThisAction.class);
registerAction(PercolateAction.INSTANCE, TransportPercolateAction.class);
registerAction(MultiPercolateAction.INSTANCE, TransportMultiPercolateAction.class, TransportShardMultiPercolateAction.class);
registerAction(ExplainAction.INSTANCE, TransportExplainAction.class);
Expand Down
46 changes: 0 additions & 46 deletions src/main/java/org/elasticsearch/action/mlt/MoreLikeThisAction.java

This file was deleted.