-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for valid parentDoc before retrieving its previous #112005
Conversation
Hi @kkrik-es, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Maybe add a unit test specifically to highlight the bug this pr is fixing? I'm ok doing this in a follow up pr (to improve CI stability quicker).
Agreed, we can add one in #111994 that also hit it. |
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
💚 Backport successful
|
) elastic#111943 unveiled a bug in `collectChilder` where we attempt to collect the previous doc of the parent, even when the parent doc has no previous doc. Fixes elastic#111990, elastic#111991, elastic#111992, elastic#111993
) elastic#111943 unveiled a bug in `collectChilder` where we attempt to collect the previous doc of the parent, even when the parent doc has no previous doc. Fixes elastic#111990, elastic#111991, elastic#111992, elastic#111993
) elastic#111943 unveiled a bug in `collectChilder` where we attempt to collect the previous doc of the parent, even when the parent doc has no previous doc. Fixes elastic#111990, elastic#111991, elastic#111992, elastic#111993
) elastic#111943 unveiled a bug in `collectChilder` where we attempt to collect the previous doc of the parent, even when the parent doc has no previous doc. Fixes elastic#111990, elastic#111991, elastic#111992, elastic#111993
#111943 unveiled a bug in
collectChilder
where we attempt to collect the previous doc of the parent, even when the parent doc has no previous doc.Fixes #111990, #111991, #111992, #111993