Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid parentDoc before retrieving its previous #112005

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

kkrik-es
Copy link
Contributor

@kkrik-es kkrik-es commented Aug 20, 2024

#111943 unveiled a bug in collectChilder where we attempt to collect the previous doc of the parent, even when the parent doc has no previous doc.

Fixes #111990, #111991, #111992, #111993

@kkrik-es kkrik-es added >bug auto-backport Automatically create backport pull requests when merged Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings v8.15.1 labels Aug 20, 2024
@kkrik-es kkrik-es self-assigned this Aug 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @kkrik-es, I've created a changelog YAML for you.

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Maybe add a unit test specifically to highlight the bug this pr is fixing? I'm ok doing this in a follow up pr (to improve CI stability quicker).

@kkrik-es
Copy link
Contributor Author

LGTM - Maybe add a unit test specifically to highlight the bug this pr is fixing? I'm ok doing this in a follow up pr (to improve CI stability quicker).

Agreed, we can add one in #111994 that also hit it.

@kkrik-es kkrik-es added auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge Automatically create backport pull requests and merge when ready and removed auto-backport Automatically create backport pull requests when merged labels Aug 20, 2024
@kkrik-es kkrik-es marked this pull request as ready for review August 20, 2024 08:06
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine merged commit 6f3fab9 into elastic:main Aug 20, 2024
15 checks passed
@kkrik-es kkrik-es deleted the fix/111992 branch August 20, 2024 08:39
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.15

kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Aug 20, 2024
)

elastic#111943 unveiled a bug in `collectChilder` where we attempt to collect
the previous doc of the parent, even when the parent doc has no previous
doc.

Fixes elastic#111990, elastic#111991, elastic#111992, elastic#111993
elasticsearchmachine pushed a commit that referenced this pull request Aug 20, 2024
…112007)

#111943 unveiled a bug in `collectChilder` where we attempt to collect
the previous doc of the parent, even when the parent doc has no previous
doc.

Fixes #111990, #111991, #111992, #111993
lkts pushed a commit to lkts/elasticsearch that referenced this pull request Aug 20, 2024
)

elastic#111943 unveiled a bug in `collectChilder` where we attempt to collect
the previous doc of the parent, even when the parent doc has no previous
doc.

Fixes elastic#111990, elastic#111991, elastic#111992, elastic#111993
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
)

elastic#111943 unveiled a bug in `collectChilder` where we attempt to collect
the previous doc of the parent, even when the parent doc has no previous
doc.

Fixes elastic#111990, elastic#111991, elastic#111992, elastic#111993
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Sep 5, 2024
)

elastic#111943 unveiled a bug in `collectChilder` where we attempt to collect
the previous doc of the parent, even when the parent doc has no previous
doc.

Fixes elastic#111990, elastic#111991, elastic#111992, elastic#111993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] StandardVersusLogsIndexModeRandomDataChallengeRestIT testMatchAllQuery failing
3 participants