Remove the dependecy on IndexFielddataService from MapperService. #12371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency was used in order for mapping updates that change the fielddata format to take effect immediately. And the way it worked was by clearing the cache of fielddata instances that were already loaded. However, we do not need to cache the already loaded (logical) fielddata instances, they are cheap to regenerate. Note that the fielddata _caches_ are still kept around so that we don't keep on rebuilding costly (physical) fielddata values.
jpountz
added
>enhancement
v2.0.0-beta1
:Search/Mapping
|
LGTM! |
jpountz
added a commit
that referenced
this pull request
Jul 22, 2015
Remove the dependecy on IndexFielddataService from MapperService.
clintongormley
removed
the
:Search/Mapping
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Jul 23, 2015
Change elastic#12371 broke fielddata on the `_parent` child for indices created before 2.0. This pull request adds back caching of the `_parent` fielddata for indices created before 2.0 and cleans some related stuff. For instance DocumentTypeListener doesn't need to take care of removed mappings anymore since mappings can't be removed in 2.0.
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency was used in order for mapping updates that change the fielddata
format to take effect immediately. And the way it worked was by clearing the
cache of fielddata instances that were already loaded. However, we do not need
to cache the already loaded (logical) fielddata instances, they are cheap to
regenerate. Note that the fielddata caches are still kept around so that we
don't keep on rebuilding costly (physical) fielddata values.