Fix fielddata handling for the _parent field.
#12418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change elastic#12371 broke fielddata on the `_parent` child for indices created before 2.0. This pull request adds back caching of the `_parent` fielddata for indices created before 2.0 and cleans some related stuff. For instance DocumentTypeListener doesn't need to take care of removed mappings anymore since mappings can't be removed in 2.0.
| @@ -232,16 +243,6 @@ public void beforeCreate(DocumentMapper mapper) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void afterRemove(DocumentMapper mapper) { | |||
There was a problem hiding this comment.
good that we partially remove this logic!
|
Left one question. LGTM |
jpountz
added a commit
that referenced
this pull request
Jul 23, 2015
Fix fielddata handling for the `_parent` field.
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change #12371 broke fielddata on the
_parentchild for indices created before2.0. This pull request adds back caching of the
_parentfielddata for indicescreated before 2.0 and cleans some related stuff. For instance
DocumentTypeListener doesn't need to take care of removed mappings anymore since
mappings can't be removed in 2.0.