Make ValueParser.DateMath aware of timezone setting #12886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a timezone field to ValueParser.DateMath that is set to UTC by default but can be set using the existing constructors. This makes it possible for extended bounds setting in DateHistogram to also use date math expressions that e.g. round by day and apply this rounding in the time zone specified in the date histogram aggregation request. Closes elastic#12278
cbuescher
changed the title
|
LGTM |
|
💯 ! 🍻 @cbuescher |
|
Any chance this will make it into the latest 1.x? Would be great! |
|
@feltnerm Sadly, I wouldn't count on it. Currently working towards 2.0, only major bugfixes get backported to the 1.x branches. |
cbuescher
added a commit
that referenced
this pull request
Aug 19, 2015
Make ValueParser.DateMath aware of timezone setting
|
@jpountz @clintongormley any opinion if this should be backported to 2.0? |
|
It's a bug fix and risks look low to me so I would say yes. |
|
Also backported to 2.0 branch with 8ba2c9b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a timezone field to ValueParser.DateMath that is
set to UTC by default but can be set using the existing constructors.
This makes it possible for extended bounds setting in DateHistogram
to also use date math expressions that e.g. round by day and apply
this rounding in the time zone specified in the date histogram
aggregation request.
Closes #12278