New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending operations in the translog prevent shard from being marked as inactive #13759

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@bleskes
Member

bleskes commented Sep 24, 2015

The IndexingMemoryController checks periodically if there is any indexing activity on the shard. If no activity is seen for 5m (default) the shard is marked as inactive allowing it's indexing buffer quota to be given to other active shards.

Sadly the current check is bad as it checks for 0 translog operations. This makes the inactive wait for a flush to happen - which used to take 30m and since #13707 doesn't happen at all (as we rely on the synced flush triggered by inactivity). This commit fixes the check so it will work with any translog size.

Internal: pending operations in the translog prevent shard from being…
… marked as inactive

The IndexingMemoryController checks periodically if there is any indexing activity on the shard. If no activity is sean for 5m (default) the shard is marked as inactive allowing it's indexing buffer quota to given to other active shards.

Sadly the current check is bad as it checks for 0 translog operation. This makes the inactive wait for a flush to happen - which used to take 30m and since #13707 doesn't happen at all (as we rely on the synced flush triggered by inactivity). This commit fixes the check so it will work with any translog size.
@kimchy

This comment has been minimized.

Show comment
Hide comment
@kimchy

kimchy Sep 24, 2015

Member

LGTM

Member

kimchy commented Sep 24, 2015

LGTM

@mikemccand

This comment has been minimized.

Show comment
Hide comment
@mikemccand

mikemccand Sep 24, 2015

Contributor

LGTM, thanks @bleskes!

Contributor

mikemccand commented Sep 24, 2015

LGTM, thanks @bleskes!

@bleskes bleskes closed this in d121550 Sep 24, 2015

bleskes added a commit that referenced this pull request Sep 24, 2015

Internal: pending operations in the translog prevent shard from being…
… marked as inactive

The IndexingMemoryController checks periodically if there is any indexing activity on the shard. If no activity is sean for 5m (default) the shard is marked as inactive allowing it's indexing buffer quota to given to other active shards.

Sadly the current check is bad as it checks for 0 translog operation. This makes the inactive wait for a flush to happen (~30m). This commit fixes the check so it will work with any translog size.

Closes #13759

bleskes added a commit that referenced this pull request Sep 24, 2015

Internal: pending operations in the translog prevent shard from being…
… marked as inactive

The IndexingMemoryController checks periodically if there is any indexing activity on the shard. If no activity is sean for 5m (default) the shard is marked as inactive allowing it's indexing buffer quota to given to other active shards.

Sadly the current check is bad as it checks for 0 translog operation. This makes the inactive wait for a flush to happen (~30m). This commit fixes the check so it will work with any translog size.

Closes #13759

bleskes added a commit that referenced this pull request Sep 24, 2015

Internal: pending operations in the translog prevent shard
 from being marked as inactive

The IndexingMemoryController checks periodically if there is any indexing activity on the shard. If no activity is sean for 5m (default) the shard is marked as inactive allowing it's indexing buffer quota to given to other active shards.

Sadly the current check is bad as it checks for 0 translog operation. This makes the inactive wait for a flush to happen (~30m). This commit fixes the check so it will work with any translog size.

Closes #13759

@bleskes bleskes deleted the bleskes:inactive_with_translog_ops branch Sep 24, 2015

@clintongormley clintongormley added the >bug label Sep 25, 2015

@clintongormley clintongormley added v2.0.0-rc1 and removed v2.0.0 labels Oct 7, 2015

@clintongormley clintongormley added :Translog and removed :Internal labels Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment