Add nicer error message when a plugin descriptor is missing #15200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
:Core/Infra/Plugins
|
The change looks good to me and can be merged. |
|
LGTM. Thanks @rjernst |
rjernst
force-pushed
the
old_plugin_error
branch
from
9e53b99
to
7c9aff9
Compare
… is missing Currently, when a user tries to install an old plugin (pre 2.x) on a 2.x node, the error message is cryptic (just printing the file path that was missing, when looking for the descriptor). This improves the message to be more explicit that the descriptor is missing, and suggests the problem might be the plugin was built before 2.0. closes elastic#15197
rjernst
force-pushed
the
old_plugin_error
branch
from
7c9aff9
to
50716c3
Compare
|
@dadoonet @bleskes I pushed a new commit which is a little better. We already check the plugin descriptor exists when unzipping a new plugin for installation, so what I had before was duplicating this at a lower level. Instead, I now detect this case where we are loading existing plugins and the descriptor is missing. |
|
LGTM |
rjernst
added a commit
that referenced
this pull request
Dec 4, 2015
Add nicer error message when a plugin descriptor is missing
rjernst
added a commit
that referenced
this pull request
Dec 4, 2015
Add nicer error message when a plugin descriptor is missing
|
2.x change: 845bc97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a user tries to install an old plugin (pre 2.x) on a 2.x
node, the error message is cryptic (just printing the file path that was
missing, when looking for the descriptor). This improves the message to
be more explicit that the descriptor is missing, and suggests the
problem might be the plugin was built before 2.0.
closes #15197