Joint parsing of common global Hightlighter and subfield parameters #15368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>enhancement
:Search Relevance/Highlighting
| highlightBuilder.options(parser.map()); | ||
| } else if (parseContext.parseFieldMatcher().match(topLevelFieldName, FIELDS_FIELD)) { | ||
| String highlightFieldName = null; | ||
| boolean rc = false; |
There was a problem hiding this comment.
can we name this something more descriptive like parsedValue or something?
|
Left a minor comment but LGTM |
cbuescher
force-pushed
the
highlight-builder-shared-parsing
branch
2 times, most recently
from
4552ed0
to
a4936d1
Compare
The top-level highlighter has many options that can be overwritten per field. Currently there is very similar code for this in two places. This PR pulls out the parsing of the common parameters into AbstractHighlighterBuilder for better reuse and to keep parsing of common parameters more consistent.
cbuescher
force-pushed
the
highlight-builder-shared-parsing
branch
from
a4936d1
to
2ab937d
Compare
|
Thanks for the review, addressed your comments and will merge. |
cbuescher
added a commit
that referenced
this pull request
Dec 14, 2015
…sing Joint parsing of common global Hightlighter and subfield parameters
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top-level highlighter has many options that can be overwritten per field. Currently there is very similar code for this in two places. This PR pulls out the parsing of the common parameters into AbstractHighlighterBuilder for better reuse and to keep parsing of common parameters more consistent.
Closes #15285