Make MetaData parsing less lenient. #15828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Add a test that it blows up if you send it garbage? |
|
@nik9000 I added a test as suggested |
|
LGTM |
Today this simply ignores everything that is not recognized.
jpountz
force-pushed
the
enhancement/stricter_metadata_parsing
branch
from
388a8de
to
6ce7a97
Compare
jpountz
added a commit
that referenced
this pull request
Jan 7, 2016
…parsing Make MetaData parsing less lenient.
clintongormley
added
:Search Foundations/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today this simply ignores everything that is not recognized.