Remove and forbid use of j.u.c.ThreadLocalRandom #15862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes and now forbids all uses of java.util.concurrent.ThreadLocalRandom across the codebase. The underlying issue with ThreadLocalRandom is that it can not be seeded. This means that if ThreadLocalRandom is used in production code, then tests that cover any code path containing ThreadLocalRandom will be prevented from being reproducible by use of ThreadLocalRandom. Instead, using org.elasticsearch.common.random.Randomness#get will give reproducible sources of random when running under tests and otherwise still give an instance of ThreadLocalRandom when running as production code.
jasontedor
added
>enhancement
>test
|
LGTM. Its convenient that this directly resolves back to ThreadLocalRandom outside of tests. It makes it simpler to review. |
jasontedor
added a commit
that referenced
this pull request
Jan 8, 2016
Remove and forbid use of j.u.c.ThreadLocalRandom Closes #15294
|
Thanks @nik9000. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes and now forbids all uses of
java.util.concurrent.ThreadLocalRandom across the codebase. The
underlying issue with ThreadLocalRandom is that it can not be
seeded. This means that if ThreadLocalRandom is used in production code,
then tests that cover any code path containing ThreadLocalRandom will be
prevented from being reproducible by use of ThreadLocalRandom. Instead,
using org.elasticsearch.common.random.Randomness#get will give
reproducible sources of random when running under tests and otherwise
still give an instance of ThreadLocalRandom when running as production
code.
Closes #15294