Make search failure cause rest failure #16889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nik9000 while you're on this, I think this issue would be of interest to you too: #16555 (comment) |
7 tasks
| @@ -41,6 +43,12 @@ protected RestStatus getStatus(R response) { | |||
| status = failure.getStatus(); | |||
| } | |||
| } | |||
| for (ShardSearchFailure failure: response.getSearchFailures()) { | |||
| RestStatus failureStatus = ExceptionsHelper.status(failure.getCause()); | |||
| if (failureStatus.getStatus() > status.getStatus()) { | |||
There was a problem hiding this comment.
This is kind of a weird way to order failures, but I guess it works. I think adding a comment might help others in the future in understanding your thinking
|
LGTM left one minor comment |
Indexing failures have caused the reindex http request to fail for a while now. Both search and indexing failures cause it to abort. But search failures didn't cause a non-200 response code from the http api. This fixes that. Also slips in a fix to some infrequently failing rest tests. Closes elastic#16037
nik9000
force-pushed
the
reindex_status_from_search_failrues
branch
from
57dc548
to
b2eec96
Compare
|
Backported to 2.x with 7b1d567 |
lcawl
added
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexing failures have caused the reindex http request to fail for a while
now. Both search and indexing failures cause it to abort. But search
failures didn't cause a non-200 response code from the http api. This
fixes that.
Also slips in a fix to some infrequently failing rest tests.
Closes #16037