Add back support for ip range aggregations.
#17859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a follow-up PR, we could make it work on legacy indices too if we think it's worth doing. But I think this PR is a good start. |
I think it would be worth doing. |
5 tasks
| Range(String key, String mask) { | ||
| String[] splits = mask.split("/"); | ||
| if (splits.length != 2) { | ||
| throw new IllegalArgumentException("Expected [ip/prefix_length] but got [" + mask + "], which contains more than one [/]"); |
There was a problem hiding this comment.
Maybe this message could be improved as it looks this exception would be thrown if the mask contains no / characters as well?
|
I left a few minor comments but otherwise LGTM |
This commit adds support for range aggregations on `ip` fields. However it will only work on 5.x indices. Closes elastic#17700
jpountz
force-pushed
the
enhancement/binary_range_agg
branch
from
5055d09
to
638da06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for range aggregations on
ipfields. However it willonly work on 5.x indices.
Closes #17700