Plugins: Add status bar on download #18695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great so far @spinscale! |
| @Override | ||
| public int read() throws IOException { | ||
| int read = in.read(); | ||
| checkProgress(read == -1 ? -1 : 1); |
There was a problem hiding this comment.
Why is the ternary needed since checkProgress handles -1?
There was a problem hiding this comment.
in.read() returns the next byte of data and not the length of the data being read, like the other to read() methods
There was a problem hiding this comment.
Ah of course. Ignore my brain fart.
|
@spinscale I left some comments. |
|
incorporated your review comments, thx for the review! |
| /** Prints message to the terminal at {@code verbosity} level, without a newline. */ | ||
| public final void print(Verbosity verbosity, String msg) { | ||
| if (this.verbosity.ordinal() >= verbosity.ordinal()) { | ||
| getWriter().print(msg); |
There was a problem hiding this comment.
I think println should be rewritten to use this?
public final void println(Verbosity verbosity, String msg) {
print(verbosity, msg + lineSeparator);
}
|
I left a couple more comments. LGTM otherwise. |
|
I checked it on a windows box and it gives the following results: Not as nice as on Linux but still working though. :) |
|
Tested on windows: Works well! |
spinscale
force-pushed
the
1606-plugin-install-progress-bar
branch
from
510f5ff
to
1d18d5c
Compare
As some plugins are becoming big now, it is hard for the user to know, if the plugin is being downloaded or just nothing happens. This commit adds a progress bar during download, which can be disabled by using the `-q` parameter. In addition this updates to jimfs 1.1, which allows us to test the batch mode, as adding security policies are now supported due to having jimfs:// protocol support in URL stream handlers.
spinscale
force-pushed
the
1606-plugin-install-progress-bar
branch
from
1d18d5c
to
50bafb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As some plugins are becoming biggish now, it is hard for the user to know, if the plugin
is being downloaded or just nothing happens. I also had some cases running on a VM where I did not know if the networking was broken or still downloading, while testing.
This commit adds a progress bar during download, which can be disabled by using the
-qparameter - it is pretty much unstyled right now, but at least shows an indicator that things are happening.
In addition this updates to jimfs 1.1, which allows us to test the batch mode, as adding
security policies are now supported due to having jimfs:// protocol support in URL stream
handlers.
TODO: Update docs
TODO: Test on windows (only tested under osx/linux so far)
This is how it looks like right now