No other processors should be executed after on_failure is called #19545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in a compound processor
talevy
added
>bug
:Data Management/Ingest Node
| @@ -19,6 +19,11 @@ | |||
| "target_field" : "date", | |||
| "formats" : ["yyyy"] | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
test verifies that uppercase processor is not executed after the date processor failed
|
Wow, a big side effect of one forgotten LGTM! |
|
yeah, all our tests only verify that the processors that did run, ran well. We never checked the effects of non-running processors |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge Fix
After debugging some use-cases with @BigFunger, we realized some unintended behavior leaked into the product.
not sure how this got through, but
on_failureprocessors should be the end-all processors. The original pipeline should not be run. This was never the intention.