Fix expect 100 continue header handling #19904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a misordering of the HTTP handlers, the Netty 4 HTTP server mishandles Expect: 100-continue headers from clients. This commit fixes this issue by ordering the handlers correctly.
jasontedor
added
>bug
review
:Distributed/Network
|
The Netty docs make the issue clear here, these handlers are just in the wrong order. |
This was referenced Aug 10, 2016
Closed
|
LGTM |
|
Is there a simple failing test we can make for this change? |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Aug 10, 2016
jasontedor
pushed a commit
that referenced
this pull request
Aug 10, 2016
* [Test] Add test for Netty4 HTTP support of header 100-continue Related to #19904 * Update after David comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a misordering of the HTTP handlers, the Netty 4 HTTP server
mishandles Expect: 100-continue headers from clients. This commit fixes
this issue by ordering the handlers correctly.
Closes #19834