Adds ignoreUnavailable option to the snapshot status API #20066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the get snapshots API which has a similar parameter. If ignoreUnavailable is set to true, then the snapshot status request will ignore any snapshots that were not found in the repository, instead of throwing a SnapshotMissingException. Closes elastic#18522
abeyad
added
>enhancement
review
:Distributed/Snapshot/Restore
| * Set to <code>true</code> to ignore unavailable snapshots, instead of throwing an exception. | ||
| * Defaults to <code>false</code>, which means unavailable snapshots cause an exception to be thrown. | ||
| * | ||
| * @param ignoreUnavailable whether to ignore unavailable snapshots |
There was a problem hiding this comment.
I don't think the @param or @return adds anything to the information. Personally I wouldn't add them. You can do what you want. I just wanted to let you know its ok (by me) not to add them if they don't make the API more clear.
There was a problem hiding this comment.
I agree, I usually don't add them but in this case I did to be consistent with the rest of the class' javadocs
|
Left a bunch of small stuff. |
| - is_true: snapshots | ||
|
|
||
| --- | ||
| teardown: |
There was a problem hiding this comment.
I'd stick this up at the top near the setup so they are together. Easier to see that they are acting together that way.
|
Left one final minor things. LGTM otherwise, merge when ready! |
|
@nik9000 thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ignoreUnavailable to the snapshot status API to be consistant
with the get snapshots API which has a similar parameter. If
ignoreUnavailable is set to true, then the snapshot status request
will ignore any snapshots that were not found in the repository,
instead of throwing a SnapshotMissingException.
Closes #18522