The root object mapper should support updating numeric_detection, date_detection and dynamic_date_formats.
#20119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>feature
:Search Foundations/Mapping
| @@ -300,9 +300,6 @@ protected static void parseProperties(ObjectMapper.Builder objBuilder, Map<Strin | |||
|
|
|||
| } | |||
|
|
|||
| protected Builder createBuilder(String name) { | |||
|
LGTM |
…date_detection` and `dynamic_date_formats`. elastic#20119 If they are specified by a mapping update, these properties are currently ignored. This commit also fixes the handling of `dynamic_templates` so that it is possible to remove templates (and so that it works more similarly to all other mapping properties). Closes elastic#20111
jpountz
force-pushed
the
fix/root_mapping_updates
branch
from
17a7837
to
f93ce94
Compare
|
Thanks @rjernst |
This was referenced Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If they are specified by a mapping update, these properties are currently
ignored. This commit also fixes the handling of
dynamic_templatesso that itis possible to remove templates (and so that it works more similarly to all
other mapping properties).
Closes #20111