Remove token_filter in _analyze API
#20285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the param and change docs Closes elastic#20283
| try { | ||
| RestAnalyzeAction.buildFromContent(content, analyzeRequest, new ParseFieldMatcher(Settings.EMPTY)); | ||
| } catch (Exception e) { | ||
| assertThat(e, instanceOf(IllegalArgumentException.class)); |
There was a problem hiding this comment.
Maybe:
Exception e = expectThrows(IllegalArgumentException.class, () -> RestAnalyzeAction.buildFromContent(content, analyzeRequest, new ParseFieldMatcher(Settings.EMPTY)));
assertThat(e.getMessage(), startsWith("Unknown parameter [token_filter]"));That way you don't have to assert the type of the exception.
|
I left some wording suggestions but otherwise LGTM. |
Fix wording in docs Refactoring RestAnalyzeActionTests using expectThrows() Closes elastic#20283
johtani
force-pushed
the
fix/remove_token_filter_param_in_analyze_api
branch
from
70f0009
to
aef2e5d
Compare
|
@nik9000 Thanks for reviewing. Updated docs and refactoring tests using expectThrows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the param and change docs
Closes #20283